.Net: Allow the MongoDB VectorData tests to run without an image#12860
Merged
westey-m merged 1 commit intoAug 6, 2025
Merged
Conversation
moonbox3
added
.NET
github-actions
Bot
changed the title
damieng
changed the title
westey-m
reviewed
Aug 5, 2025
westey-m
reviewed
Aug 5, 2025
damieng
force-pushed
the
allow-mongodb-tests-with-connection-string
branch
from
b54fffb to
e9bf06e
Compare
westey-m
approved these changes
Aug 6, 2025
markwallace-microsoft
approved these changes
Aug 6, 2025
jcruzmot-te
pushed a commit
to thousandeyes/aia-semantic-kernel
that referenced
this pull request
Sep 15, 2025
…rosoft#12860) ### Motivation and Context We are running the SK tests in our https://github.com/mongodb-labs/ai-ml-pipeline-testing repo and would like to also be able to run them against live MongoDB Atlas clusters for further verification rather than just the Docker image. ### Description The PR adjusts the vector data tests (only as per @roji recommendation) so that if an environment variable named `MONGODB__CONNECTIONURL` exists then that is used to connect to MongoDB rather than using TestContainers to fire up a Docker image of MongoDB Atlas. Additionally to improve reliability it was found that we need to increase the number of attempts to wait for the data to be ready after creating an index. (Bumped from 20 to 200). We're going to look at adding index status helper methods in the C# Driver going forward for a better experience. Once this is done we should be able to fully enable the new tests on our repo and diagnose any further instabilities and then be able to submit a PR to fully-enable the image-based tests here. ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
We are running the SK tests in our https://github.com/mongodb-labs/ai-ml-pipeline-testing repo and would like to also be able to run them against live MongoDB Atlas clusters for further verification rather than just the Docker image.
Description
The PR adjusts the vector data tests (only as per @roji recommendation) so that if an environment variable named
MONGODB__CONNECTIONURLexists then that is used to connect to MongoDB rather than using TestContainers to fire up a Docker image of MongoDB Atlas.Additionally to improve reliability it was found that we need to increase the number of attempts to wait for the data to be ready after creating an index. (Bumped from 20 to 200). We're going to look at adding index status helper methods in the C# Driver going forward for a better experience.
Once this is done we should be able to fully enable the new tests on our repo and diagnose any further instabilities and then be able to submit a PR to fully-enable the image-based tests here.
Contribution Checklist